From 51ef9d749396178f8b909f9744e550b8972d44a6 Mon Sep 17 00:00:00 2001 From: denz1994 Date: Fri, 21 Dec 2018 10:08:36 -0500 Subject: [PATCH] Added REVIEW comments https://github.com/phetsims/fractions-common/issues/29 --- js/building/model/ShapePiece.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/building/model/ShapePiece.js b/js/building/model/ShapePiece.js index cbeb719..7eeb549 100644 --- a/js/building/model/ShapePiece.js +++ b/js/building/model/ShapePiece.js @@ -97,9 +97,12 @@ define( require => { // Handle rotational animation towards a target (if any) Property.multilink( [ this.isUserControlledProperty, this.targetRotationProperty ], ( isUserControlled, targetRotation ) => { if ( isUserControlled ) { + // REVIEW: 'let' instead of 'var' var currentRotation = this.rotationProperty.value; this.trueTargetRotation = Animator.modifiedEndAngle( currentRotation, this.targetRotationProperty.value ); + // REVIEW: 'let' instead of 'var' + // REVIEW: Documentation for these variables would be helpful, being they are only used below. var damping = 1; var force = 50; this.dampedHarmonicTimeElapsed = 0;