Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sound is heard when "Jump to Min/Max" keyboard shortcuts are used #192

Closed
Nancy-Salpepi opened this issue Sep 28, 2021 · 2 comments
Closed
Assignees

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
11.6

Browser
chrome

Problem description
phetsims/qa#711

No sound is produced when the home/end keys are used to jump to min/max values. This is seen on the Discrete Screen for the number of Harmonics as well as Wavelength and Period values. This also occurs in the Wave Game Screen for the amplitude values.

Steps to reproduce

  1. On the discrete screen, tab to the Harmonics spinner.
  2. Use the "Home" and "End" keys to adjust value to min and max.

Visuals

nosound2.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Fourier: Making Waves‬ URL: https://phet-dev.colorado.edu/html/fourier-making-waves/1.0.0-rc.1/phet/fourier-making-waves_all_phet.html Version: 1.0.0-rc.1 2021-09-28 15:44:23 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36 Language: en-US Window: 1391x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@pixelzoom
Copy link
Contributor

The amplitude sliders use an adhoc implemenation for sound, intended as a temporary solution until common-code work is done for phetsims/sun#697 (Slider sound API). This adhoc implementation is by no means complete. It only supports sound when dragging (with a pointer or keyboard). Clicking in the track (without dragging) or moving to the min/max with the keyboard is not at all supported.

@arouinfar let me know if you want anything else added to this adhoc implementation. If not, please close.

@pixelzoom
Copy link
Contributor

9/30/21 design meeting:

We're not going to address this issue for the adhoc implementation in Fourier. It will be generally addressed in phetsims/sun#697.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants