From 6d1610035059b083e1b2d2520d183fc7d3113385 Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Mon, 5 Jun 2023 17:24:11 -0600 Subject: [PATCH] rename some fields in FMWDerivedStrings, https://github.com/phetsims/fourier-making-waves/issues/235 --- js/common/FMWDerivedStrings.ts | 12 ++++++------ js/common/view/DomainComboBox.ts | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/js/common/FMWDerivedStrings.ts b/js/common/FMWDerivedStrings.ts index 3efa084e..df772f5f 100644 --- a/js/common/FMWDerivedStrings.ts +++ b/js/common/FMWDerivedStrings.ts @@ -43,23 +43,23 @@ const FMWDerivedStrings = { tandem: DERIVED_STRINGS_TANDEM.createTandem( 'xMillisecondsStringProperty' ) } ), - spaceXStringProperty: new PatternStringProperty( FourierMakingWavesStrings.spaceSymbolStringProperty, { + functionOfSpaceStringProperty: new PatternStringProperty( FourierMakingWavesStrings.spaceSymbolStringProperty, { symbol: FMWSymbols.xMarkupStringProperty }, { - tandem: DERIVED_STRINGS_TANDEM.createTandem( 'spaceXStringProperty' ) + tandem: DERIVED_STRINGS_TANDEM.createTandem( 'functionOfSpaceStringProperty' ) } ), - timeTStringProperty: new PatternStringProperty( FourierMakingWavesStrings.timeSymbolStringProperty, { + functionOfTimeStringProperty: new PatternStringProperty( FourierMakingWavesStrings.timeSymbolStringProperty, { symbol: FMWSymbols.tMarkupStringProperty }, { - tandem: DERIVED_STRINGS_TANDEM.createTandem( 'timeTStringProperty' ) + tandem: DERIVED_STRINGS_TANDEM.createTandem( 'functionOfTimeStringProperty' ) } ), - spaceAndTimeXTStringProperty: new PatternStringProperty( FourierMakingWavesStrings.spaceAndTimeSymbolsStringProperty, { + functionOfSpaceAndTimeStringProperty: new PatternStringProperty( FourierMakingWavesStrings.spaceAndTimeSymbolsStringProperty, { spaceSymbol: FMWSymbols.xMarkupStringProperty, timeSymbol: FMWSymbols.tMarkupStringProperty }, { - tandem: DERIVED_STRINGS_TANDEM.createTandem( 'spaceAndTimeXTStringProperty' ) + tandem: DERIVED_STRINGS_TANDEM.createTandem( 'functionOfSpaceAndTimeStringProperty' ) } ), lambdaAndTStringProperty: new PatternStringProperty( FourierMakingWavesStrings.symbolAndSymbolStringProperty, { diff --git a/js/common/view/DomainComboBox.ts b/js/common/view/DomainComboBox.ts index cf7d358a..4243f9e2 100644 --- a/js/common/view/DomainComboBox.ts +++ b/js/common/view/DomainComboBox.ts @@ -20,17 +20,17 @@ import FMWDerivedStrings from '../FMWDerivedStrings.js'; const CHOICES: FMWComboBoxChoice[] = [ { value: Domain.SPACE, - stringProperty: FMWDerivedStrings.spaceXStringProperty, + stringProperty: FMWDerivedStrings.functionOfSpaceStringProperty, tandemName: `space${ComboBox.ITEM_TANDEM_NAME_SUFFIX}` }, { value: Domain.TIME, - stringProperty: FMWDerivedStrings.timeTStringProperty, + stringProperty: FMWDerivedStrings.functionOfTimeStringProperty, tandemName: `time${ComboBox.ITEM_TANDEM_NAME_SUFFIX}` }, { value: Domain.SPACE_AND_TIME, - stringProperty: FMWDerivedStrings.spaceAndTimeXTStringProperty, + stringProperty: FMWDerivedStrings.functionOfSpaceAndTimeStringProperty, tandemName: `spaceAndTime${ComboBox.ITEM_TANDEM_NAME_SUFFIX}` } ];