From 0578974556dda584300dd09cc1d3461bf7292633 Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Mon, 20 Sep 2021 16:42:30 -0600 Subject: [PATCH] fix non-existent font option for SumSymbolNode, https://github.com/phetsims/fourier-making-waves/issues/165 --- js/common/view/SumSymbolNode.js | 2 +- js/discrete/view/DiscreteSumEquationNode.js | 4 +--- js/wavepacket/view/WavePacketSumEquationNode.js | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/js/common/view/SumSymbolNode.js b/js/common/view/SumSymbolNode.js index d5f121cc..9df51e16 100644 --- a/js/common/view/SumSymbolNode.js +++ b/js/common/view/SumSymbolNode.js @@ -35,7 +35,7 @@ class SumSymbolNode extends Node { // SumSymbolNode options integration: false, // true=integration, false=summation fontSize: 30, - indexFontSize: 12 + indexFontSize: 15 }, options ); // The symbol for the type of sum. diff --git a/js/discrete/view/DiscreteSumEquationNode.js b/js/discrete/view/DiscreteSumEquationNode.js index a11fe08a..ff8c67cc 100644 --- a/js/discrete/view/DiscreteSumEquationNode.js +++ b/js/discrete/view/DiscreteSumEquationNode.js @@ -54,9 +54,7 @@ class DiscreteSumEquationNode extends Node { } ); // Capital sigma, summation symbol - const summationNode = new SumSymbolNode( n, 1, numberOfHarmonicsProperty, { - font: options.font //REVIEW: I don't see a `font` option in SumSymbolNode, should we be pulling out fontSize? - } ); + const summationNode = new SumSymbolNode( n, 1, numberOfHarmonicsProperty ); // Everything to the right of the summation symbol, set in multilink below const rightNode = new RichText( '', { diff --git a/js/wavepacket/view/WavePacketSumEquationNode.js b/js/wavepacket/view/WavePacketSumEquationNode.js index d903478b..a1ee4599 100644 --- a/js/wavepacket/view/WavePacketSumEquationNode.js +++ b/js/wavepacket/view/WavePacketSumEquationNode.js @@ -48,8 +48,6 @@ class WavePacketSumEquationNode extends Node { // Capital sigma, summation symbol const sumSymbolNode = new SumSymbolNode( FMWSymbols.n, -Infinity, new NumberProperty( Infinity ), { - //REVIEW: No `font` option in SumSymbolNode that I can find - font: options.font, indexFontSize: 15 } );