Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation version? #96

Closed
jonathanolson opened this issue May 23, 2017 · 4 comments
Closed

Simulation version? #96

jonathanolson opened this issue May 23, 2017 · 4 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Looks like there's a 1.0-phetio branch, with 1.0.1 published. That would imply we would start off with 1.0.2 as a version for the main sim when it is visible?

Is Expression Exchange currently a live phet-io sim?

For the code review #88

@jbphet
Copy link
Contributor

jbphet commented May 24, 2017

An early version that included phet-io was released in support of a study, see #57. This excluded the game. As a result, we should probably start with a new branch when this release process starts, and the branch name should be 1.1. The first release with therefore be 1.1.0. Back to you @jonathanolson to say whether you have concerns or objections, and for closure if this sounds okay.

@jonathanolson
Copy link
Contributor Author

I recommend changing to 1.1.0-dev.1 then in package.json?

@jbphet
Copy link
Contributor

jbphet commented May 30, 2017

Ah, an excellent point. I've done this in 5453745. Tagging @phet-steele and @amanda-phet so that they are aware that the version numbers have been updated in this way, since it will affect upcoming dev and RC releases.

@jbphet
Copy link
Contributor

jbphet commented Jun 5, 2017

Version number is now corrected, closing.

@jbphet jbphet closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants