Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer area issues #127

Closed
1 of 2 tasks
pixelzoom opened this issue Jun 18, 2018 · 3 comments
Closed
1 of 2 tasks

pointer area issues #127

pixelzoom opened this issue Jun 18, 2018 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 18, 2018

I pulled these comments from @mbarlow12 out of #123, where he also said:

The only issue I found has to do with the pointer areas as noted above. This may be standard behavior (I don't have much experience with optimizing/handling/debugging pointer areas), and if so, please disregard those comments.


  • Are pointer areas optimized, especially for touch? (run with query parameter showPointerAreas)
    // REVIEW
    • There appear to be some discrepancies between draggable/clickable areas and their associated sim elements. The terms in the toolboxes have non-interactive space between the pointer area lines and the objects themselves:

ee-pointer1 ee-pointer2

  • While this is most prominent in the term toolboxes, it also appears in the equation accordion toggle button, all clickable items in the snapshots accordion box, the organize button, the universal operator buttons, and the lock control.

  • There is also a discrepancy between the blue and red pointer area outlines for the following components: accordion box toggles, universal operator buttons, snapshot icons (incl. the delete & restore buttons), the organize button, and the variable number tweaker (incl. EE, EETwoVariables, and EEBasics Lab).

screen shot 2018-06-16 at 4 30 14 pm screen shot 2018-06-16 at 4 30 27 pm


  • Do pointer areas overlap? (run with query parameter showPointerAreas) Some overlap may be OK depending on the z-ordering (if the frontmost object is supposed to occlude touch/mouse areas)
@pixelzoom pixelzoom self-assigned this Jun 18, 2018
@pixelzoom pixelzoom mentioned this issue Jun 18, 2018
97 tasks
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 18, 2018

There appear to be some discrepancies between draggable/clickable areas and their associated sim elements.

Yes, this is the purpose of pointerAreas. We typically expand the interactive (draggable/clickable) areas of an element to make it easier to drag. The red dashed line indicates the interactive area for touch devices (aka touchArea), the blue dashed line indicates the interactive area for mouse devices (aka mouseArea).

While this is most prominent in the term toolboxes, it also appears in the equation accordion toggle button, all clickable items in the snapshots accordion box, the organize button, the universal operator buttons, and the lock control.

Yes, these are all as requested. For example, here's the request for the terms in toolboxes: #68 (comment)

There is also a discrepancy between the blue and red pointer area outlines for the following components:

mouseAreas (blue) and touchAreas(red) are almost always different, with touchAreas being larger. That's what you're seeing here.

Some overlap may be OK depending on the z-ordering (if the frontmost object is supposed to occlude touch/mouse areas)

The code review items doesn't make this clear. But we're looking for cases where mouseAreas (blue) overlap with other mouseAreas, and ditto for touchAreas. I took another look, and I don't see any overlap.

@pixelzoom
Copy link
Contributor Author

@mbarlow12 Review my comment above and let me know if you have any questions. If you're confident that there is no problem here, feel free to close.

@pixelzoom pixelzoom assigned mbarlow12 and unassigned pixelzoom Jun 18, 2018
@mbarlow12
Copy link

@pixelzoom That makes sense, and thanks for clarifying the color mapping. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants