Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MagnifyingGlassZoomButtonGroup #315

Closed
samreid opened this issue Dec 14, 2020 · 2 comments
Closed

Use MagnifyingGlassZoomButtonGroup #315

samreid opened this issue Dec 14, 2020 · 2 comments
Assignees
@arouinfar

Comments

@samreid
Copy link
Member

samreid commented Dec 14, 2020

Scenery-phet now has support for ZoomButtonGroup, it seems like Energy Skate Park could delete many lines of code if it used that new common code.

Noticed during phetsims/circuit-construction-kit-common#620
@jessegreenberg
Copy link
Contributor

I read through phetsims/circuit-construction-kit-common#620 and it seems likely that this would be a sim to use ZoomButtonGroup because it looks more modern and there isn't overload in concept with "+" and "-" symbols in this sim. Using ZoomButtonGroup will be tracked in #313.

@arouinfar can you please review and close if you agree?

@arouinfar
Copy link
Contributor

I think we will probably end up using ZoomButtonGroup, but that's something we'll decide on in #313 during the PhET-iO design review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @jessegreenberg @arouinfar