Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skater can fall outside of loop and skater can fall through track #421

Closed
megan-phet opened this issue Jul 10, 2018 · 5 comments
Closed

Comments

@megan-phet
Copy link

megan-phet commented Jul 10, 2018

Test device:

  • MacBook Pro

Operating System:

  • macOS 10.13.5

Browser:

  • All latest

phetsims/qa/issues/134 Are these acceptable behaviors?

@jessegreenberg
Copy link
Contributor

Stepping through EnergySkateParkBasicsModel.interactWithTracksWhileFalling, it looks like this.crossedTrack is returning false in these cases.

@jessegreenberg
Copy link
Contributor

Time consuming to iterate/create test tracks but I just found debugTrack query parameter will be really helpful. @ariel-phet can you please review this issue and prioritize, should it be fixed for the phetio/LoL release?

@jessegreenberg
Copy link
Contributor

The first video is a duplicate of #434. The second video looks like something different.

@ariel-phet
Copy link

@jessegreenberg the second video is interesting...since there is presumably no friction (which is what the sim state appears to be set to) it seems like the skater should go around indefinitely. This seems like a pretty clever case to set up, and I am a bit surprised the behavior changes...maybe some sensitive dependence on conditions and floating point error type thing?

Anyhow, the second video warrants investigation, but I would put it at low priority. Would be nice to figure out what is going on, but no necessarily crucial since this sim has been out in the world for quite awhile without any complaints about the physics.

@jessegreenberg
Copy link
Contributor

The first video is a duplicate of #434.

And #434 was closed because this type of track is not pedagogically useful.

Ill make a new issue for the "Skater falls out of loop" problem in energy-skate-park.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants