Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can events be removed from Track.js? #408

Closed
jessegreenberg opened this issue Feb 23, 2018 · 2 comments
Closed

Can events be removed from Track.js? #408

jessegreenberg opened this issue Feb 23, 2018 · 2 comments
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Feb 23, 2018 •
edited
Loading

It looks like Track.js used to be driven by axon/Events.js, but sim now uses Emitter. Sim search for .events shows one reference in Track.js, the definition. I believe events can be removed from instance variables in Track.js. The events arg could be renamed to model, all usages of new Track pass in an EnergySkateParkBasicsModel as first arg.
@jessegreenberg jessegreenberg self-assigned this Feb 23, 2018
@jessegreenberg
Copy link
Contributor Author

For #398.

@jessegreenberg jessegreenberg mentioned this issue Jul 2, 2018
Closed
@jessegreenberg
Copy link
Contributor Author

No need to do this issue in ESP:B, moved to ESP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg