Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can EnergySkateParkBasicsModel.time be removed? #404

Closed
jessegreenberg opened this issue Feb 22, 2018 · 1 comment
Closed

Can EnergySkateParkBasicsModel.time be removed? #404

jessegreenberg opened this issue Feb 22, 2018 · 1 comment
Labels
dev:code-review

Comments

@jessegreenberg
Copy link
Contributor

For #398, I see

    // elapsed time in the sim, in seconds.
    this.time = 0;

this.time gets incremented in step but I see no other usages. Can it be removed?
@jessegreenberg jessegreenberg changed the title Can this.time be removed? Can EnergySkateParkBasicsModel.time be removed? Feb 22, 2018
jessegreenberg referenced this issue in phetsims/energy-skate-park Jul 2, 2018
@jessegreenberg
Remove unused time variable, see phetsims/energy-skate-park#404
50d7e4a
@jessegreenberg
Copy link
Contributor Author

Removed in the above commit in energy-skate-park.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg