Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need separate home screen and navbar images? #401

Closed
jessegreenberg opened this issue Feb 1, 2018 · 1 comment
Closed

Do we need separate home screen and navbar images? #401

jessegreenberg opened this issue Feb 1, 2018 · 1 comment
Labels
dev:code-review

Comments

@jessegreenberg
Copy link
Contributor

From #398, EnergySkateParkBasicsScreen.js has icon-{{screen}}-homescreen.png and icon-{{screen}}-navbar.png for homescreen and navbar icons. They look like identical images with different scale. Maybe these were added before Screen.js automatically scaled down homeScreenIcon. Can we just use one image for home screen/nav bar icons?
@jessegreenberg jessegreenberg mentioned this issue Jul 2, 2018
Closed
@jessegreenberg
Copy link
Contributor Author

If anything is going to be done, it should be done in ESP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg