-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sim needs retesting after PropertySet=>Property refactoring #371
Labels
Comments
@samreid sounds good, unassigning for now |
ariel-phet
added
status:ready-for-review
and removed
status:fixed-pending-testing
labels
May 31, 2018
This is going to get tested in phetsims/qa#134. |
jessegreenberg
added
status:fixed-pending-testing
and removed
status:ready-for-review
labels
Jun 20, 2018
This is being tested and has been linked to the issue, removing my assignment. |
ariel-phet
added
status:ready-for-review
and removed
status:fixed-pending-testing
labels
May 1, 2019
energy-skate-park has gone through a few dev tests since this change, this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For phetsims/axon#102 the simulation was rewritten to use Property instead of PropertySet. This was not straightforward for the following reasons:
The commits are everything between
059e011
and
73f2382
I've tested manually and run fuzz tests with assertions enabled and found (and solved) several lurking problems. There may be others. This sim should get some QA attention before being republished. I recommend waiting until we want to publish another version from master in case other fixes like this are made between now and then (to avoid duplicating QA work), since the sim will likely need to be tested before next publication anyways. Assigning @ariel-phet so he is aware of this issue.
The text was updated successfully, but these errors were encountered: