cannot determine if dispose requirements have been met

[pixelzoom]

Related to code review #247

• Do all types that require a dispose function have one? This should expose a public dispose function that calls this.disposeMyType(), where disposeMyType is a private function declared in the constructor. MyType should exactly match the filename.

Searching for dispose() {, I find only 2 definitions of dispose. Due to deficiencies in #244 and #265, I have no way to determine if this is sufficient. implementation-notes.md should include this information in a general description of memory management. See for example the "Memory Management" subsection of https://github.com/phetsims/gas-properties/blob/master/doc/implementation-notes.md#general-considerations.

[pixelzoom]

Ditto for:

• For each common-code component (sun, scenery-phet, vegas, …) that opaquely registers observers or listeners, is there a call to that component’s dispose function, or is it obvious why it isn't necessary, or is there documentation about why dispose isn't called? An example of why no call to dispose is needed is if the component is used in a screen view that would never be removed from the scene graph.

[chrisklus]

The two defined dispose functions are in EnergyChunkNode and EnergyChunkWanderController. Another dynamic type, ElementFollower, has a method stopFollowing which unlinks its locationBeingFollowedProperty.

A similar blanket statement was added to implementation notes over in #265

There are also not any dynamically allocated UI common-code components used in this sim.

@jbphet and I are ready to close.