Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector2Property to get units? #107

Closed
zepumph opened this issue Feb 25, 2021 · 3 comments
Closed

Vector2Property to get units? #107

zepumph opened this issue Feb 25, 2021 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Feb 25, 2021

For PhET-iO, it was requested that some Vector2 Properties could get units. I think it would be awesome to add this. @samreid what do you think? I was just going to use units.js and copy the same sort of pattern as NumberProperty. Then add that to studio.

See phetsims/projectile-motion#219 for the requests for places like:

Units to:
projectileMotion.introScreen.model.measuringTape.basePositionProperty: m
projectileMotion.introScreen.model.measuringTape.tipPositionProperty: m
projectileMotion.introScreen.model.tracer.positionProperty: m

@samreid
Copy link
Member

samreid commented Feb 25, 2021

Units are already implemented in Property, not in NumberProperty, so it is possible Vector2Property already has support for units.

@samreid samreid removed their assignment Feb 25, 2021
@zepumph
Copy link
Member Author

zepumph commented Feb 25, 2021

Oh I see. Let me see better. BTW this would be best to link phetsims/projectile-motion#244 to.

@zepumph
Copy link
Member Author

zepumph commented Feb 25, 2021

Seems like it! Thanks for the reminder. Sorry to bother.

image

@zepumph zepumph closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants