Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighing bug #194

Closed
lesha724 opened this issue Mar 15, 2024 · 7 comments
Closed

Weighing bug #194

lesha724 opened this issue Mar 15, 2024 · 7 comments
Labels
status:on-hold type:bug Something isn't working

Comments

@lesha724
Copy link

lesha724 commented Mar 15, 2024

Hello, I have bug with weight in mystery section:

image
image
image
image
image

@zepumph
Copy link
Member

zepumph commented Mar 15, 2024

Thanks for the submission. I will take a look and bring it to my team.

@zepumph zepumph added the type:bug Something isn't working label Mar 15, 2024
@zepumph zepumph self-assigned this Mar 15, 2024
@lesha724
Copy link
Author

@zepumph, Thanks

@zepumph
Copy link
Member

zepumph commented Mar 15, 2024

This may be related to phetsims/buoyancy#64

@zepumph
Copy link
Member

zepumph commented Apr 13, 2024

I was able to reproduce the problem. I can see that the value can change depending on how I drop the top block onto the bottom one. I sometimes got a value like: 19.704819877536927, and other times, 19.70501456941877. I will see if it is just a dividing error slop, or if it is in part from some of the tolerances built into the P2 physics engine. If it is the latter, we may decide not to change this, since values for stiffness/relaxation/etc have been fine tuned to fix many other bugs (see here).

@AgustinVallejo AgustinVallejo added the dev:help-wanted Extra attention is needed label Apr 16, 2024
@zepumph zepumph removed their assignment May 7, 2024
@AgustinVallejo AgustinVallejo self-assigned this May 16, 2024
@AgustinVallejo AgustinVallejo added status:on-hold and removed dev:help-wanted Extra attention is needed status:on-hold labels May 16, 2024
@AgustinVallejo
Copy link
Contributor

We're experimenting with a solution for phetsims/buoyancy#64 that might affect this. On hold

@AgustinVallejo
Copy link
Contributor

phetsims/buoyancy#167 This fix made this issue dissappear as well. Closing

@zepumph
Copy link
Member

zepumph commented May 31, 2024

This bug was reported by an outside party (thank you for doing that). It isn't clear that we are republishing this sim with the publication of buoyancy, and if not this is still a bug in production. Let's keep this open until confirming that we are planning to republish density also. Otherwise we may consider an MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:on-hold type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants