From 69f5f662e8ebdbefcd1398b1b4b8c539b35ceb96 Mon Sep 17 00:00:00 2001
From: Jonathan Olson <jonathan.olson@colorado.edu>
Date: Fri, 12 Aug 2022 20:18:41 -0600
Subject: [PATCH] stringProperties experimentation

---
 js/compare/CompareScreen.ts | 4 +---
 js/density-main.ts          | 4 +---
 js/densityStrings.ts        | 5 +++++
 js/intro/IntroScreen.ts     | 4 +---
 js/mystery/MysteryScreen.ts | 4 +---
 5 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/js/compare/CompareScreen.ts b/js/compare/CompareScreen.ts
index 38ccf21..9d4eaf7 100644
--- a/js/compare/CompareScreen.ts
+++ b/js/compare/CompareScreen.ts
@@ -19,8 +19,6 @@ import compare_screen_icon_png from '../../mipmaps/compare_screen_icon_png.js';
 import density from '../density.js';
 import densityStrings from '../densityStrings.js';
 
-const screenCompareString = densityStrings.screen.compare;
-
 export default class CompareScreen extends Screen<DensityCompareModel, DensityCompareScreenView> {
   public constructor( tandem: Tandem ) {
     const icon = DensityBuoyancyCommonQueryParameters.generateIconImages ? DensityBuoyancyScreenView.getDensityCompareIcon() : new Image( compare_screen_icon_png );
@@ -33,7 +31,7 @@ export default class CompareScreen extends Screen<DensityCompareModel, DensityCo
         tandem: tandem.createTandem( 'view' )
       } ),
       {
-        name: screenCompareString,
+        name: densityStrings.screen.compareProperty,
         backgroundColorProperty: DensityBuoyancyCommonColors.skyBottomProperty,
         homeScreenIcon: new ScreenIcon( icon, {
           maxIconWidthProportion: 1,
diff --git a/js/density-main.ts b/js/density-main.ts
index b1ff241..01f7348 100644
--- a/js/density-main.ts
+++ b/js/density-main.ts
@@ -14,8 +14,6 @@ import CompareScreen from './compare/CompareScreen.js';
 import IntroScreen from './intro/IntroScreen.js';
 import MysteryScreen from './mystery/MysteryScreen.js';
 
-const densityTitleString = densityStrings.density.title;
-
 const simOptions: SimOptions = {
   credits: {
     //TODO fill in credits, all of these fields are optional, see joist.CreditsNode
@@ -36,7 +34,7 @@ const simOptions: SimOptions = {
 // launch the sim - beware that scenery Image nodes created outside of simLauncher.launch() will have zero bounds
 // until the images are fully loaded, see https://github.com/phetsims/coulombs-law/issues/70
 simLauncher.launch( () => {
-  const sim = new Sim( densityTitleString, [
+  const sim = new Sim( densityStrings.density.titleProperty, [
     new IntroScreen( Tandem.ROOT.createTandem( 'introScreen' ) ),
     new CompareScreen( Tandem.ROOT.createTandem( 'compareScreen' ) ),
     new MysteryScreen( Tandem.ROOT.createTandem( 'mysteryScreen' ) )
diff --git a/js/densityStrings.ts b/js/densityStrings.ts
index db125b7..63b4787 100644
--- a/js/densityStrings.ts
+++ b/js/densityStrings.ts
@@ -5,16 +5,21 @@
  */
 /* eslint-disable */
 import getStringModule from '../../chipper/js/getStringModule.js';
+import Property from '../../axon/js/Property.js';
 import density from './density.js';
 
 type StringsType = {
   'density': {
     'title': string;
+    'titleProperty': Property<string>;
   };
   'screen': {
     'intro': string;
+    'introProperty': Property<string>;
     'compare': string;
+    'compareProperty': Property<string>;
     'mystery': string;
+    'mysteryProperty': Property<string>;
   }
 };
 
diff --git a/js/intro/IntroScreen.ts b/js/intro/IntroScreen.ts
index ddf46e8..e773f0e 100644
--- a/js/intro/IntroScreen.ts
+++ b/js/intro/IntroScreen.ts
@@ -19,8 +19,6 @@ import intro_screen_icon_png from '../../mipmaps/intro_screen_icon_png.js';
 import density from '../density.js';
 import densityStrings from '../densityStrings.js';
 
-const screenIntroString = densityStrings.screen.intro;
-
 export default class IntroScreen extends Screen<DensityIntroModel, DensityIntroScreenView> {
   public constructor( tandem: Tandem ) {
     const icon = DensityBuoyancyCommonQueryParameters.generateIconImages ? DensityBuoyancyScreenView.getDensityIntroIcon() : new Image( intro_screen_icon_png );
@@ -33,7 +31,7 @@ export default class IntroScreen extends Screen<DensityIntroModel, DensityIntroS
         tandem: tandem.createTandem( 'view' )
       } ),
       {
-        name: screenIntroString,
+        name: densityStrings.screen.introProperty,
         backgroundColorProperty: DensityBuoyancyCommonColors.skyBottomProperty,
         homeScreenIcon: new ScreenIcon( icon, {
           maxIconWidthProportion: 1,
diff --git a/js/mystery/MysteryScreen.ts b/js/mystery/MysteryScreen.ts
index 211e520..9666e2d 100644
--- a/js/mystery/MysteryScreen.ts
+++ b/js/mystery/MysteryScreen.ts
@@ -19,8 +19,6 @@ import mystery_screen_icon_png from '../../mipmaps/mystery_screen_icon_png.js';
 import density from '../density.js';
 import densityStrings from '../densityStrings.js';
 
-const screenMysteryString = densityStrings.screen.mystery;
-
 export default class MysteryScreen extends Screen<DensityMysteryModel, DensityMysteryScreenView> {
   public constructor( tandem: Tandem ) {
     const icon = DensityBuoyancyCommonQueryParameters.generateIconImages ? DensityBuoyancyScreenView.getDensityMysteryIcon() : new Image( mystery_screen_icon_png );
@@ -33,7 +31,7 @@ export default class MysteryScreen extends Screen<DensityMysteryModel, DensityMy
         tandem: tandem.createTandem( 'view' )
       } ),
       {
-        name: screenMysteryString,
+        name: densityStrings.screen.mysteryProperty,
         backgroundColorProperty: DensityBuoyancyCommonColors.skyBottomProperty,
         homeScreenIcon: new ScreenIcon( icon, {
           maxIconWidthProportion: 1,