From bf40a1ca87139dd7992c0297f3b4b8b93fa05a36 Mon Sep 17 00:00:00 2001 From: Sam Reid <reids@colorado.edu> Date: Tue, 7 May 2024 09:32:37 -0600 Subject: [PATCH] Make abstract constructors protected, see https://github.com/phetsims/density-buoyancy-common/issues/123 --- js/buoyancy/model/ApplicationsMass.ts | 4 ++-- js/buoyancy/view/ReadoutListAccordionBox.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/buoyancy/model/ApplicationsMass.ts b/js/buoyancy/model/ApplicationsMass.ts index c0eedf9e..677c54bf 100644 --- a/js/buoyancy/model/ApplicationsMass.ts +++ b/js/buoyancy/model/ApplicationsMass.ts @@ -3,7 +3,7 @@ /** * A general class for shared functionality between the boat and bottle. * - * @author Agustín Vallejo + * @author Agustín Vallejo (PhET Interactive Simulations) */ import NumberProperty from '../../../../axon/js/NumberProperty.js'; @@ -27,7 +27,7 @@ export default abstract class ApplicationsMass extends Mass { public readonly intersectionGroup: THREE.Group; - public constructor( engine: PhysicsEngine, displacementVolumeProperty: NumberProperty, options: ApplicationsMassOptions ) { + protected constructor( engine: PhysicsEngine, displacementVolumeProperty: NumberProperty, options: ApplicationsMassOptions ) { assert && assert( !options.canRotate ); diff --git a/js/buoyancy/view/ReadoutListAccordionBox.ts b/js/buoyancy/view/ReadoutListAccordionBox.ts index ae9da03d..a06506fa 100644 --- a/js/buoyancy/view/ReadoutListAccordionBox.ts +++ b/js/buoyancy/view/ReadoutListAccordionBox.ts @@ -60,7 +60,7 @@ export default abstract class ReadoutListAccordionBox<ReadoutType> extends Accor protected readonly readoutBox: VBox; protected readonly contentWidthMaxProperty: TReadOnlyProperty<number>; - public constructor( + protected constructor( titleStringProperty: TReadOnlyProperty<string>, providedOptions?: ReadoutListAccordionBoxOptions<ReadoutType> ) {