From 839365037de4b3b3325b2bec95dc522257edce90 Mon Sep 17 00:00:00 2001 From: Sam Reid Date: Fri, 19 Jul 2024 12:20:29 -0600 Subject: [PATCH] Make the gravity property no longer phetioReadOnly: true, see https://github.com/phetsims/density-buoyancy-common/issues/256 --- js/common/model/DensityBuoyancyModel.ts | 1 - js/common/model/Material.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/js/common/model/DensityBuoyancyModel.ts b/js/common/model/DensityBuoyancyModel.ts index 93f34ae3..7ccbd217 100644 --- a/js/common/model/DensityBuoyancyModel.ts +++ b/js/common/model/DensityBuoyancyModel.ts @@ -74,7 +74,6 @@ export default class DensityBuoyancyModel implements TModel { valueType: Gravity, phetioValueType: ReferenceIO( IOType.ObjectIO ), tandem: tandem.createTandem( 'gravityProperty' ), - phetioReadOnly: true, phetioDocumentation: 'The acceleration due to gravity applied to all masses, (may be potentially custom or hidden from view)' } ); diff --git a/js/common/model/Material.ts b/js/common/model/Material.ts index 1edf1ddf..0ae2feee 100644 --- a/js/common/model/Material.ts +++ b/js/common/model/Material.ts @@ -5,7 +5,6 @@ * * TODO: Add Migration processors for changes that made Material and Gravity mutable, see https://github.com/phetsims/density-buoyancy-common/issues/256 * - * TODO: see https://github.com/phetsims/density-buoyancy-common/issues/256 make the gravity property not read only * TODO: see https://github.com/phetsims/density-buoyancy-common/issues/256 there was a bug when changing the custom density of a block in screen 1 * TODO: see https://github.com/phetsims/density-buoyancy-common/issues/256 buoyancy.labScreen.model.pool.fluid.displacedVolumeProperty change units to L * TODO: see https://github.com/phetsims/density-buoyancy-common/issues/256 buoyancy.labScreen.model.block.sizeProperty has no units