diff --git a/js/buoyancy/view/applications/BuoyancyApplicationsScreenView.ts b/js/buoyancy/view/applications/BuoyancyApplicationsScreenView.ts index 02a24bed..58581bfc 100644 --- a/js/buoyancy/view/applications/BuoyancyApplicationsScreenView.ts +++ b/js/buoyancy/view/applications/BuoyancyApplicationsScreenView.ts @@ -137,7 +137,11 @@ export default class BuoyancyApplicationsScreenView extends BuoyancyScreenView cuboid.updateSize( Cube.boundsFromVolume( cubicMeters ) ), listParent, numberControlMassPropertyFeatured, options ); @@ -45,9 +51,27 @@ export default class BlockControlNode extends MaterialMassVolumeControlNode { const densityNumberControlTandem = options.tandem.createTandem( 'densityNumberControl' ); - // TODO: Lots of work needed here, https://github.com/phetsims/density-buoyancy-common/issues/256 - // TODO: Manually set material to custom when this property changes? https://github.com/phetsims/density-buoyancy-common/issues/256 - const customDensityProperty = new NumberProperty( 1000, {} ); + const customDensityProperty = cuboid.materialProperty.customMaterial.densityProperty; + + let isChangingToPredefinedMaterialLock = false; + + // When the user changes the density by dragging the slider, automatically switch from the predefined material to + // the custom material + customDensityProperty.lazyLink( () => { + if ( !isChangingToPredefinedMaterialLock ) { + cuboid.materialProperty.value = cuboid.materialProperty.customMaterial; + } + } ); + + // In the explore screen, when switching from custom to wood, change the density back to the wood density + cuboid.materialProperty.lazyLink( material => { + if ( !material.custom ) { + + isChangingToPredefinedMaterialLock = true; + customDensityProperty.value = material.density; + isChangingToPredefinedMaterialLock = false; + } + } ); const densityAsLitersProperty = new UnitConversionProperty( customDensityProperty, { factor: 1 / DensityBuoyancyCommonConstants.LITERS_IN_CUBIC_METER diff --git a/js/common/view/MaterialControlNode.ts b/js/common/view/MaterialControlNode.ts index c236eeed..f9509876 100644 --- a/js/common/view/MaterialControlNode.ts +++ b/js/common/view/MaterialControlNode.ts @@ -16,12 +16,14 @@ import DensityBuoyancyCommonConstants from '../DensityBuoyancyCommonConstants.js import Material from '../model/Material.js'; import { PhetioObjectOptions } from '../../../../tandem/js/PhetioObject.js'; import PickRequired from '../../../../phet-core/js/types/PickRequired.js'; -import Utils from '../../../../dot/js/Utils.js'; import densityBuoyancyCommon from '../../densityBuoyancyCommon.js'; import MaterialProperty from '../model/MaterialProperty.js'; +import Utils from '../../../../dot/js/Utils.js'; type SelfMaterialControlNodeOptions = { + syncCustomMaterialDensity?: boolean; + // A label, if provided to be placed to the right of the ComboBox labelNode?: Node | null; @@ -51,6 +53,7 @@ export default class MaterialControlNode extends VBox { const options = optionize()( { + syncCustomMaterialDensity: true, labelNode: null, supportCustomMaterial: true, supportHiddenMaterial: false, @@ -95,15 +98,17 @@ export default class MaterialControlNode extends VBox { }; // When switching to custom, set the custom density to the previous material's density (clamped just in case) - materialProperty.lazyLink( ( material, oldMaterial ) => { - if ( material.custom ) { - assert && assert( materialProperty.customMaterial === customMaterials[ 0 ], 'I would really rather know what customMaterial we are dealing with' ); - - // Handle our minimum volume if we're switched to custom (if needed) - const maxVolume = Math.max( volumeProperty.value, options.minCustomVolumeLiters / DensityBuoyancyCommonConstants.LITERS_IN_CUBIC_METER ); - materialProperty.customMaterial.densityProperty.value = Utils.clamp( oldMaterial.density, options.minCustomMass / maxVolume, options.maxCustomMass / maxVolume ); - } - } ); + if ( options.syncCustomMaterialDensity ) { + materialProperty.lazyLink( ( material, oldMaterial ) => { + if ( material.custom ) { + assert && assert( materialProperty.customMaterial === customMaterials[ 0 ], 'I would really rather know what customMaterial we are dealing with' ); + + // Handle our minimum volume if we're switched to custom (if needed) + const maxVolume = Math.max( volumeProperty.value, options.minCustomVolumeLiters / DensityBuoyancyCommonConstants.LITERS_IN_CUBIC_METER ); + materialProperty.customMaterial.densityProperty.value = Utils.clamp( oldMaterial.density, options.minCustomMass / maxVolume, options.maxCustomMass / maxVolume ); + } + } ); + } // TODO: But can we just use the validValues of the provided MaterialProperty, https://github.com/phetsims/density-buoyancy-common/issues/256 // TODO: But hidden ones!!! https://github.com/phetsims/density-buoyancy-common/issues/256