-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch Areas for Sliders Overlap #76
Comments
TL:DR One approach includes adjusting the touch areas of the thumb node. However, we don't have access to the thumb node touch area because it is localized within HSlider (a common object used in other sims). We could add an option parameter to HSlider object that adjusts the touch area. Currently, the touch area on the slider thumb node has a default value that depends only on the size of the thumb node. If we wanted to adjust the touch area around the thumb node, we would have to adjust size of the thumb node itself. This may cause issues in formatting due to space limitations. Having an option to divorce the touch area from the thumb node is one approach, but would require an adjustment to HSlider. This adjustment could be made to not affect any other simulation using HSlider, but at the same time allow for flexibility. SUN/js/HSlider.js - lines 37-53
SUN/js/HSlider.js - lines 111-119
The changes to note are :
We would now be able to pass any touch area dilation as an option to any object that uses the HSlider object. *Note: These changes can be made to adjust the horizontal/vertical independently or scale both together by a common factor. The latter is implemented in the above code. |
I found that there is a Sun Issue, see phetsims/sun#202 |
We need to add options related to the thumb's touchArea and mouseArea to HSlider. See comment phetsims/sun#202 (comment). |
Duplicate of #72. Closing. |
Slider pointer areas overlap. This may interfere with touch device functionality.
The text was updated successfully, but these errors were encountered: