Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sounds for the wavelength sliders #144

Open
jbphet opened this issue Aug 11, 2022 · 3 comments
Open

Add sounds for the wavelength sliders #144

jbphet opened this issue Aug 11, 2022 · 3 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 11, 2022

The parent issue for this is #138.

The first screen of Color Vision has two sliders for controlling wavelengths, see the screenshot below. We should add sounds for these.

image

@jbphet
Copy link
Contributor Author

jbphet commented Aug 11, 2022

@Ashton-Morris created the following mockup for this:

- Color_Vision_Mockup_Single_Bulb_Filter_Color_Options_On_Pause_3_Types.mp4 This video has three base sounds that play when you move the filter color slider. This would only work when the sim is paused if we implemented it. But I am playing the whole spectrum of the sounds and then they are going through a bandpass filter which looks a lot like the filter on the color spectrum.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 11, 2022

Assigning to @Ashton-Morris for a bit more design work. Once we've agreed on an initial direction, I'll start implementation.

@jbphet
Copy link
Contributor Author

jbphet commented Sep 6, 2022

As of 8/30/2022, work on adding sound to this simulation is being paused. I'll mark this issue as deferred, and we will hopefully return to it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants