Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about utteranceQueue #122

Closed
samreid opened this issue May 11, 2018 · 10 comments
Closed

Questions about utteranceQueue #122

samreid opened this issue May 11, 2018 · 10 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented May 11, 2018

While exploring #121 I wanted to investigate having the sim say "the flashlight turned on" when the user presses the button. I added this code to SingleBulbScreenView.js constructor:

    model.flashlightOnProperty.link( function( flashlightOn ) {
      utteranceQueue.addToBack(flashlightOn ? 'The flashlight turned on.':'The flashlight turned off.');
    } );

With VoiceOver on, after it read through the initial pdom, I pushed the button several times, and then it said "the flashlight turned on" and "the flashlight turned off" several times, then would no longer say the message even if I kept pressing the button. Am I doing this correctly? Is there a bug or a misunderstanding of how this is supposed to behave?

@jessegreenberg
Copy link
Contributor

@samreid I would expect it to say it once for every time you pressed the button. I tested the snippet in the original comment with Safari + VO and I hear it consistently. Were you using Safari or another browser? Did you happen to switch browser tabs? There is a VO bug where all alerts stop if you switch tabs.

@samreid
Copy link
Member Author

samreid commented May 11, 2018

I was using Chrome Version 66.0.3359.139 (Official Build) (64-bit) and did not switch tabs. Let me know if you can reproduce the problem on Mac/Chrome, or if you want me to try to reproduce the problem.

@zepumph
Copy link
Member

zepumph commented May 11, 2018

For me, windows version 66.0.3359.139 (Official Build) (64-bit), I added that code to that file and it worked for me consistently. I switched tabs and it still worked as expected.

@zepumph zepumph removed their assignment May 11, 2018
@samreid
Copy link
Member Author

samreid commented May 11, 2018

Were you using NVDA?

@jessegreenberg
Copy link
Contributor

@samreid can you please try in Safari? Chrome is not a browser that we test with screen readers.

@zepumph
Copy link
Member

zepumph commented May 11, 2018

Were you using NVDA?

I was using NVDA, sorry to leave that out.

@samreid can you please try in Safari? Chrome is not a browser that we test with screen readers.

I should have known better @jessegreenberg, my deepest and most regretful apologies. I should only use Firefox on windows with NVDA.

@jessegreenberg
Copy link
Contributor

Still good to know @zepumph, makes a good data point!

@samreid samreid self-assigned this May 14, 2018
@ariel-phet
Copy link

Removing @samreid assignment for now, as color vision isn't scheduled for work at the moment

@pixelzoom
Copy link
Contributor

@jessegreenberg can this be closed, and/or promoted to a common-code issue? It doesn't seem specific to color-vision.

@jessegreenberg
Copy link
Contributor

This can be closed, utteranceQueue has received many changes since this issue, and recently went through QA testing in phetsims/qa#208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants