Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PhetColorScheme be updated? #148

Closed
brandonLi8 opened this issue Aug 20, 2020 · 4 comments
Closed

Should PhetColorScheme be updated? #148

brandonLi8 opened this issue Aug 20, 2020 · 4 comments
Assignees

Comments

@brandonLi8
Copy link
Contributor

From the CRC:

  • Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in

I marked this as failing for now. I took a look at PhetColorScheme, and there are 3 things that could potentially be updated.

  1. According to PhetColorScheme, acceleration is green. Luckily, there are 0 usages of this! My recommendation would be to change this to yellow and update sims like projectile motion and collision lab (and others?) to use this constant.

  2. According to PhetColorScheme, velocity is red-colorblind. Luckily, there are 0 usages of this! My recommendation would be to change this to green and update sims like projectile motion and collision lab (and others?) to use this constant.

  3. There is no momentum in PhetColorScheme. We should probably add momentum using the color that collision lab is using.

@arouinfar @ariel-phet should I proceed with this?

@ariel-phet
Copy link

@brandonLi8 yes go ahead and make this change

@arouinfar
Copy link
Contributor

arouinfar commented Aug 26, 2020

@brandonLi8 I opened an issue in scenery-phet to track these changes.

@jonathanolson
Copy link
Contributor

Should be good in master, @arouinfar can you verify?

@arouinfar
Copy link
Contributor

Looks good in master. Thanks @jonathanolson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants