You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in
I marked this as failing for now. I took a look at PhetColorScheme, and there are 3 things that could potentially be updated.
According to PhetColorScheme, acceleration is green. Luckily, there are 0 usages of this! My recommendation would be to change this to yellow and update sims like projectile motion and collision lab (and others?) to use this constant.
According to PhetColorScheme, velocity is red-colorblind. Luckily, there are 0 usages of this! My recommendation would be to change this to green and update sims like projectile motion and collision lab (and others?) to use this constant.
There is no momentum in PhetColorScheme. We should probably add momentum using the color that collision lab is using.
From the CRC:
I marked this as failing for now. I took a look at PhetColorScheme, and there are 3 things that could potentially be updated.
According to PhetColorScheme, acceleration is green. Luckily, there are 0 usages of this! My recommendation would be to change this to yellow and update sims like projectile motion and collision lab (and others?) to use this constant.
According to PhetColorScheme, velocity is red-colorblind. Luckily, there are 0 usages of this! My recommendation would be to change this to green and update sims like projectile motion and collision lab (and others?) to use this constant.
There is no momentum in PhetColorScheme. We should probably add momentum using the color that collision lab is using.
@arouinfar @ariel-phet should I proceed with this?
The text was updated successfully, but these errors were encountered: