Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate stepper option to Carousel #437

Closed
pixelzoom opened this issue Aug 24, 2018 · 2 comments
Closed

evaluate stepper option to Carousel #437

pixelzoom opened this issue Aug 24, 2018 · 2 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Carousel was converted to use TWIXT/Animation in phetsims/sun#381. The default is stepper: 'manual', which means that the client must call step to control the Carousel's animation. To avoid having to make changes in this sim, stepper: 'timer' was added to Carousel call sites, which means that the animation will run automatically using the sim Timer.

The responsible developer should evaluate what stepper value should be used.

@samreid
Copy link
Member

samreid commented Aug 26, 2018

We are discussing using an {Emitter} instead of a {string}, defaulting to the PHET_CORE Timer emitter, in phetsims/twixt#19. I'll put the issue on hold until that is complete.

@samreid
Copy link
Member

samreid commented Sep 28, 2019

Since this carousel is decoupled from the model, it can run using the default value of timer. Closing.

@samreid samreid closed this as completed Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants