Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vertex pushing #132

Closed
samreid opened this issue Jun 14, 2016 · 1 comment
Closed

More vertex pushing #132

samreid opened this issue Jun 14, 2016 · 1 comment

Comments

@samreid
Copy link
Member

samreid commented Jun 14, 2016

From #125

In general, this seems to be working, but in reviewing #113, I ran into this situation.

rotation

The battery and resistor on the right side of the black box look like they may have potentially overlapped, so the resistor rotated. However, the the components didn't actually connect.

and

@phet-steele found another interesting case:
vertexpushing

After the vertex is cut, the central vertices are likely close enough to trigger the rotating behavior, but the wires don't seem to "realize" they are too close until another component is brought close.

The few issues I've observed seem to be edge cases, rather than blocking issues. I'm going to reassign to @samreid, as I'm not sure how he'll want to proceed.

@samreid
Copy link
Member Author

samreid commented Jun 14, 2016

Oops, duplicate, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant