Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.10-rc.1] TypeError: Cannot read property 'branch' of null #67

Open
ghost opened this issue Jun 13, 2018 · 6 comments
Open

[1.0.10-rc.1] TypeError: Cannot read property 'branch' of null #67

ghost opened this issue Jun 13, 2018 · 6 comments
Assignees
@KatieWoe
Labels
dev:phet-io type:bug

Comments

@ghost
Copy link

ghost commented Jun 13, 2018

Test Device

MacBook Air

Operating System

macOS 10.13.5

Browser

Google Chrome 67.0.3396.79

Problem Description

For phetsims/qa/issues/128. Found in https://phet-dev.colorado.edu/html/circuit-construction-kit-black-box-study/1.0.10-rc.1/circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone. I connected multiple wires, the sim became uninteractable, and I saw this error in the console:

Uncaught TypeError: Cannot read property 'branch' of null
    at e.propagate (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938)
    at e.step (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938)
    at e.step (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938)
    at e.step (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:939)
    at i.stepSimulation (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965)
    at i.runAnimationLoop (circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965)
propagate @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938
step @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938
step @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:938
step @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:939
stepSimulation @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965
requestAnimationFrame (async)
runAnimationLoop @ circuit-construction-kit-black-box-study_en-phetio.html?phet-io.standalone:965

Steps to Reproduce

I haven't been able to reproduce yet, and it looks like something CT would throw. I'll try fuzzing for a while.

Visuals

screen shot 2018-06-12 at 3 31 25 pm
@ghost ghost assigned zepumph Jun 13, 2018
@zepumph zepumph mentioned this issue Jun 13, 2018
Closed
@zepumph
Copy link
Member

zepumph commented Jun 14, 2018

@lmulhall-phet please reassign if you find it reproducible in this version but not in the previous version.

@zepumph zepumph assigned ghost and unassigned zepumph Jun 14, 2018
@zepumph
Copy link
Member

zepumph commented Jun 28, 2018

Pinging @lmulhall-phet to make sure this bug wasn't introduced in this RC.

@ghost
Copy link
Author

ghost commented Jun 28, 2018

@zepumph, I haven't been able to reproduce, so I can't say.

I'm fuzzing now, and I'll try to recreate the exact conditions for the bug later today.

@zepumph
Copy link
Member

zepumph commented Jun 28, 2018

The fact that it is so difficult to reproduce makes me feel like this is outside the scope of fixing for this maintenance release, let me know if you think otherwise.

@ghost
Copy link
Author

ghost commented Jun 28, 2018

@zepumph, I agree.

@ghost ghost assigned KatieWoe Jul 20, 2018
@ghost ghost assigned liammulh and unassigned ghost Jul 16, 2020
@liammulh
Copy link
Member

Un-assigning myself since I no longer work on QA.

@liammulh liammulh removed their assignment Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
dev:phet-io type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zepumph @KatieWoe @liammulh