Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the black box screen, reset all doesn't reset the selected black box #57

Open
samreid opened this issue May 24, 2017 · 1 comment
Open

Comments

@samreid
Copy link
Member

samreid commented May 24, 2017

From phetsims/circuit-construction-kit-common#123

@samreid said

Typically the reset all button should reset the entire screen. In #122 I noticed that reset all doesn't go back to the "warm up" black box, but I realized this may not be desirable in this case. @arouinfar can you please advise?

@arouinfar said:

@samreid I took a look at dev.14. It looks like Reset All only affects the active black box. The state of the other black boxes is still saved. I could see this being a useful feature in an interview setting. A student may build something particularly messy, and want to clear it without losing their work on other black boxes.

For Stanford's purposes, I think we should leave the behavior like it is, and tell them that a browser refresh will be necessary to completely reset the sim.

When the time comes to develop a Black Box sim for the PhET site, we may want to rethink this behavior. I'm going to leave this issue open, but on hold for future discussion at a design meeting.

On second thought, probably best to leave this one assigned to me.

@arouinfar
Copy link

@samreid I think ResetAllButton should have a uniform behavior across all sims, so it should reset ALL black boxes. We could add a separate reset button that would affect only the current black box.

@arouinfar arouinfar removed their assignment May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants