Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we document/describe build-local.json? #915

Open
zepumph opened this issue Mar 19, 2020 · 2 comments
Open

How should we document/describe build-local.json? #915

zepumph opened this issue Mar 19, 2020 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 19, 2020

Very similar from #913 (comment), we may want to apply the pattern developed over there for package.json files to build-local.json. Marking on hold for now.

Also during the meeting @samreid mentioned that we support a schema-type module for our build-local.json, but that is not true from what I see here in chipper's Gruntfile.js:

  // Handle the lack of build.json
  let buildLocal;
  try {
    buildLocal = grunt.file.readJSON( process.env.HOME + '/.phet/build-local.json' );
  }
  catch( e ) {
    buildLocal = {};
  }

Perhaps the next step will be to do the same thing for build-local.

@samreid
Copy link
Member

samreid commented Mar 19, 2020

We have this: perennial/js/common/buildLocal.js, but perhaps it isn't used everywhere it could or should be?

@zepumph
Copy link
Member Author

zepumph commented Mar 19, 2020

Oh I see! I didn't find it in chipper! Perhaps we can use the same sort of pattern as was discussed in #913 to make this available to chipper's grunt file as well. This will be more consistent for all repos.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants