Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions about eslint config #735

Closed
zepumph opened this issue Jan 17, 2019 · 2 comments
Closed

Questions about eslint config #735

zepumph opened this issue Jan 17, 2019 · 2 comments
Assignees
@samreid @zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Jan 17, 2019

While working on phetsims/tasks#972 (comment), I found some questions:

    // For use in aqua tests
    // underscore, lodash
    '_': true,

Why is this overwritable? I would think it would be read-only
@zepumph
Copy link
Member Author

zepumph commented Jan 17, 2019

'window': false,

When I commented this out, there were 52 failures, but that seemed weird to me, because I would think that that would be covered by the browser env globals.

@zepumph
Copy link
Member Author

zepumph commented Jan 17, 2019

Closing this issue as a duplicate of #731

@zepumph zepumph closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph