Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'grunt deploy-rc' doesn't check whether version already exists #581

Closed
pixelzoom opened this issue Jun 5, 2017 · 9 comments
Closed

'grunt deploy-rc' doesn't check whether version already exists #581

pixelzoom opened this issue Jun 5, 2017 · 9 comments

Comments

@pixelzoom
Copy link
Contributor

'grunt deploy-rc' doesn't check whether version already exists. And if the version does already exist (which is will if you forget to manually update package.json), then it will quite happily overwrite the existing version. Which I just did with function-builder-basics 1.0.2.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 5, 2017

Btw... 'grunt deploy-dev' checks to see whether the version already exists (see #561). Why doesn't 'grunt deploy-rc' do the same?

@jonathanolson
Copy link
Contributor

Would this check on the client-side or build-server side?

@mattpen
Copy link
Contributor

mattpen commented Jun 8, 2017

Client side should check for existing RC and production deploys. I'll implement this.

@zepumph
Copy link
Member

zepumph commented Oct 12, 2017

This may be done for us because versioning will be automated, but we should still have this check.

@zepumph zepumph assigned jessegreenberg and zepumph and unassigned mattpen Oct 12, 2017
@jessegreenberg
Copy link
Contributor

@jessegreenberg and @zepumph will give this a shot!

@mattpen
Copy link
Contributor

mattpen commented Oct 12, 2017

@jessegreenberg and @zepumph here is the current check in deploy-dev: 383755b

@jonathanolson
Copy link
Contributor

This is handled on the perennial-side deployment, tagging for testing.

@pixelzoom
Copy link
Contributor Author

Following the chipper 2.0 merge, I suspect that this can be closed?

@jonathanolson
Copy link
Contributor

Correct, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants