-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'grunt deploy-rc' doesn't check whether version already exists #581
Comments
Btw... 'grunt deploy-dev' checks to see whether the version already exists (see #561). Why doesn't 'grunt deploy-rc' do the same? |
Would this check on the client-side or build-server side? |
Client side should check for existing RC and production deploys. I'll implement this. |
This may be done for us because versioning will be automated, but we should still have this check. |
@jessegreenberg and @zepumph will give this a shot! |
@jessegreenberg and @zepumph here is the current check in deploy-dev: 383755b |
This is handled on the perennial-side deployment, tagging for testing. |
Following the chipper 2.0 merge, I suspect that this can be closed? |
Correct, closing. Thanks! |
'grunt deploy-rc' doesn't check whether version already exists. And if the version does already exist (which is will if you forget to manually update package.json), then it will quite happily overwrite the existing version. Which I just did with function-builder-basics 1.0.2.
The text was updated successfully, but these errors were encountered: