call trim before ChipperStringUtils.addDirectionalFormatting, #619

phetsims · Nov 9, 2017 · f7be23c · f7be23c
1 parent 93ef7f9
commit f7be23c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/js/grunt/getStringMap.js b/js/grunt/getStringMap.js
@@ -83,6 +83,9 @@ module.exports = function( grunt, buildConfig ) {
 
       for ( var stringKeyMissingPrefix in fileContents ) {
         var stringData = fileContents[ stringKeyMissingPrefix ];
+
+        // remove leading/trailing whitespace, see chipper#619. Do this before addDirectionalFormatting
+        stringData.value = stringData.value.trim();
         stringData.value = ChipperStringUtils.addDirectionalFormatting( stringData.value, isRTL );
 
         // Add the requirejs namespaces (eg, JOIST) to the key

diff --git a/js/requirejs-plugins/string.js b/js/requirejs-plugins/string.js
@@ -60,6 +60,9 @@ define( function( require ) {
       text.get( url, function( loadedText ) {
         var parsed = parse( loadedText );
         for ( var stringKey in parsed ) {
+
+          // remove leading/trailing whitespace, see chipper#619. Do this before addDirectionalFormatting
+          parsed[ stringKey ].value = parsed[ stringKey ].value.trim();
           parsed[ stringKey ].value = ChipperStringUtils.addDirectionalFormatting( parsed[ stringKey ].value, isRTL );
         }
         cache[ url ] = parsed;