Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragIndicatorNode sometimes above 14th ball in State wrapper #130

Closed
Nancy-Salpepi opened this issue Apr 9, 2022 · 6 comments
Closed

DragIndicatorNode sometimes above 14th ball in State wrapper #130

Nancy-Salpepi opened this issue Apr 9, 2022 · 6 comments
Assignees
Labels
dev:help-wanted Extra attention is needed type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.31.1

Browser
Safari

Problem description
For phetsims/qa#795 in the State Wrapper:
Sometimes the dragIndicatorNode appears above the 14th ball instead of the 15th in the downstream sim.

Steps to reproduce

  1. In the state wrapper, press the Kick 5 button 3 times
  2. Press Reset All and repeat step 1 (you may need to do this several times)

I have also seen this when setting the state with set state rate = 0.

Visuals

dragcue.mp4
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Apr 9, 2022
@Nancy-Salpepi
Copy link
Author

I was also able to reproduce this in the Studio wrapper on both screens and in the PhET brand sim. It seems to occur when the 14th ball lands after the 15th ball.

@samreid
Copy link
Member

samreid commented Apr 12, 2022

@chrisklus and I think this would be appropriate for discussion for 1.1.

@samreid samreid added this to the 1.1 Publication milestone Apr 12, 2022
@samreid samreid removed this from the Publish 1.1 milestone Apr 21, 2023
@samreid samreid self-assigned this Apr 21, 2023
@samreid
Copy link
Member

samreid commented Apr 21, 2023

I was able to reproduce this problem.

@samreid
Copy link
Member

samreid commented Apr 22, 2023

I was going to ask if we really like using PhetioGroup in this sim, or if we want to abandon it and eagerly create all objects, and use the isActiveProperty like we used in Mean: Share and Balance. That would likely solve this problem (though it is not the only way to solve it).

@samreid samreid removed their assignment Apr 22, 2023
@samreid samreid added the dev:help-wanted Extra attention is needed label Apr 22, 2023
@samreid
Copy link
Member

samreid commented Apr 25, 2023

Today we discussed that we should probably move toward static elements and isActiveProperty. We agreed it will be ok in studio to see all 15 things even though they aren't active. I proposed visual UI that grays out inactive items in the tree, but we were told that is not needed.

@samreid samreid self-assigned this Apr 25, 2023
@samreid
Copy link
Member

samreid commented Apr 28, 2023

This looks fixed after #160, closing.

@samreid samreid closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:help-wanted Extra attention is needed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants