From f5c1ed66e5c1f7e137862421d83aaa72b04937c7 Mon Sep 17 00:00:00 2001 From: Sam Reid Date: Thu, 4 May 2023 06:12:15 -0600 Subject: [PATCH] Update TODOs, see https://github.com/phetsims/center-and-variability/issues/45 --- js/variability/model/VariabilityModel.ts | 17 +++-------------- js/variability/view/IQRInfoNode.ts | 3 ++- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/js/variability/model/VariabilityModel.ts b/js/variability/model/VariabilityModel.ts index 78939718..5bce4bb9 100644 --- a/js/variability/model/VariabilityModel.ts +++ b/js/variability/model/VariabilityModel.ts @@ -35,21 +35,10 @@ export default class VariabilityModel extends CAVModel { public constructor( options: VariabilityModelOptions ) { - - // this.selectedDistributionProperty.link( distribution => { - // - // // TODO: the parent class sets this incorrectly on reset. - // // TODO: PhET-iO wants to be able to set these values. Maybe in the preferences, we would also add a "custom" - // // option that would allow the user to specify the distribution parameters. Or for PhET-iO, and query parameters - // this.distributionProperty.value = - // distribution === DistributionType.KICKER_1 ? [ 0, 0, 0, 1, 3, 10, 18, 20, 18, 10, 3, 1, 0, 0, 0 ] : - // distribution === DistributionType.KICKER_2 ? [ 5, 5, 10, 10, 25, 30, 40, 50, 40, 30, 25, 10, 10, 5, 5 ] : - // distribution === DistributionType.KICKER_3 ? [ 6, 9, 11, 14, 11, 8, 6, 5, 5, 5, 5, 5, 5, 5, 5 ] : - // /*KICKER_4*/ [ 5, 5, 5, 5, 5, 5, 5, 5, 6, 8, 11, 14, 11, 9, 6 ]; - // } ); + // TODO: the parent class sets this incorrectly on reset. + // TODO: PhET-iO wants to be able to set these values. Maybe in the preferences, we would also add a "custom" + // option that would allow the user to specify the distribution parameters. Or for PhET-iO, and query parameters const sceneModels = [ - - // TODO: Each of these should have its own distribution new VariabilitySceneModel( [ 0, 0, 0, 1, 3, 10, 18, 20, 18, 10, 3, 1, 0, 0, 0 ], { tandem: options.tandem.createTandem( 'sceneModel1' ) } ), new VariabilitySceneModel( [ 5, 5, 10, 10, 25, 30, 40, 50, 40, 30, 25, 10, 10, 5, 5 ], { tandem: options.tandem.createTandem( 'sceneModel2' ) } ), new VariabilitySceneModel( [ 6, 9, 11, 14, 11, 8, 6, 5, 5, 5, 5, 5, 5, 5, 5 ], { tandem: options.tandem.createTandem( 'sceneModel3' ) } ), diff --git a/js/variability/view/IQRInfoNode.ts b/js/variability/view/IQRInfoNode.ts index 4dd85713..a93c7a1d 100644 --- a/js/variability/view/IQRInfoNode.ts +++ b/js/variability/view/IQRInfoNode.ts @@ -28,9 +28,10 @@ export default class IQRInfoNode extends VBox { maxWidth: CAVConstants.INFO_DIALOG_MAX_TEXT_WIDTH, layoutOptions: { bottomMargin: 10 } } ), + + // TODO: Double check all string key names new Text( CenterAndVariabilityStrings.iqrDescriptionStringProperty, { fontSize: 18, maxWidth: CAVConstants.INFO_DIALOG_MAX_TEXT_WIDTH } ), - // TODO: String key name distancesText, new Text( new PatternStringProperty( CenterAndVariabilityStrings.iqrCalculationPattern1StringProperty, {