From e46e2d65a101ded3eb42e0bd95ad7d981600be79 Mon Sep 17 00:00:00 2001 From: Sam Reid Date: Fri, 5 May 2023 08:47:15 -0600 Subject: [PATCH] Update TODOs, see https://github.com/phetsims/center-and-variability/issues/45 --- js/common/view/CAVScreenView.ts | 2 +- js/median/view/CardNode.ts | 2 +- js/median/view/CardNodeContainer.ts | 2 +- js/variability/model/VariabilityModel.ts | 2 +- js/variability/view/InfoDialog.ts | 2 +- js/variability/view/MADInfoNode.ts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/js/common/view/CAVScreenView.ts b/js/common/view/CAVScreenView.ts index e2e1c171..bd09aa18 100644 --- a/js/common/view/CAVScreenView.ts +++ b/js/common/view/CAVScreenView.ts @@ -153,7 +153,7 @@ export default class CAVScreenView extends ScreenView { } ) ); // Soccer balls go behind the accordion box after they land - // TODO: Why is the back layer in the front? + // TODO: Why is the back layer in the front? See https://github.com/phetsims/center-and-variability/issues/176 this.contentLayer.addChild( this.backObjectLayer ); } diff --git a/js/median/view/CardNode.ts b/js/median/view/CardNode.ts index efff4075..ac31e3dc 100644 --- a/js/median/view/CardNode.ts +++ b/js/median/view/CardNode.ts @@ -102,7 +102,7 @@ export default class CardNode extends Node { if ( destination.equals( this.animationTo! ) ) { // Already moving to the desired destination. - // TODO: should this callback be called from the finishEmitter of the existing animation? + // TODO: should this callback be called from the finishEmitter of the existing animation? See https://github.com/phetsims/center-and-variability/issues/177 callback(); return; } diff --git a/js/median/view/CardNodeContainer.ts b/js/median/view/CardNodeContainer.ts index df8b7b74..8e82d3d0 100644 --- a/js/median/view/CardNodeContainer.ts +++ b/js/median/view/CardNodeContainer.ts @@ -102,7 +102,7 @@ export default class CardNodeContainer extends Node { if ( isPressed ) { - // TODO: multitouch concerns. Should it be null|true|false? Or maybe after celebration, set it to true because we know it is sorted? + // TODO: multitouch concerns. Should it be null|true|false? Or maybe after celebration, set it to true because we know it is sorted? See https://github.com/phetsims/center-and-variability/issues/178 this.wasSortedBefore = this.isDataSorted(); } diff --git a/js/variability/model/VariabilityModel.ts b/js/variability/model/VariabilityModel.ts index 4089fab8..f30f298d 100644 --- a/js/variability/model/VariabilityModel.ts +++ b/js/variability/model/VariabilityModel.ts @@ -35,7 +35,7 @@ export default class VariabilityModel extends CAVModel { public constructor( options: VariabilityModelOptions ) { - // TODO: the parent class sets this incorrectly on reset. + // TODO: the parent class sets this incorrectly on reset. See https://github.com/phetsims/center-and-variability/issues/164 // TODO: See https://github.com/phetsims/center-and-variability/issues/117. PhET-iO wants to be able to set these values. Maybe in the preferences, we would also add a "custom" // option that would allow the user to specify the distribution parameters. Or for PhET-iO, and query parameters const sceneModels = [ diff --git a/js/variability/view/InfoDialog.ts b/js/variability/view/InfoDialog.ts index 2c50ff1f..6098013a 100644 --- a/js/variability/view/InfoDialog.ts +++ b/js/variability/view/InfoDialog.ts @@ -33,7 +33,7 @@ export default class InfoDialog extends Dialog { super( content, { - // TODO: It seems there are 2 ways to hide the dialog. Is there a better way? + // TODO: It seems there are 2 ways to hide the dialog. Is there a better way? See https://github.com/phetsims/center-and-variability/issues/179 hideCallback: () => model.isInfoShowingProperty.set( false ) } ); } diff --git a/js/variability/view/MADInfoNode.ts b/js/variability/view/MADInfoNode.ts index cc988739..1d4f7436 100644 --- a/js/variability/view/MADInfoNode.ts +++ b/js/variability/view/MADInfoNode.ts @@ -17,7 +17,7 @@ import VariabilitySceneModel from '../model/VariabilitySceneModel.js'; export default class MADInfoNode extends VBox { public constructor( model: VariabilityModel, sceneModel: VariabilitySceneModel, options: PickRequired ) { - // TODO: The design calls for a depiction of the mean location. This is not yet implemented. + // TODO: The design calls for a depiction of the mean location. This is not yet implemented. See https://github.com/phetsims/center-and-variability/issues/180 const hasEnoughDataProperty = new DerivedProperty( [ sceneModel.numberOfDataPointsProperty ], numberOfDataPoints => numberOfDataPoints >= 1 ); const numeratorText = new Text( '', { fontSize: 16 } );