From 3b9ce7a85c4bb8b6392e363937be4719c3198456 Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Mon, 26 Sep 2022 15:41:50 -0600 Subject: [PATCH] fix memory leak in QuestionBar, https://github.com/phetsims/scenery-phet/issues/771 --- js/mean-and-median/view/MeanAndMedianScreenView.ts | 2 +- js/median/view/MedianScreenView.ts | 2 +- js/variability/view/VariabilityScreenView.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/mean-and-median/view/MeanAndMedianScreenView.ts b/js/mean-and-median/view/MeanAndMedianScreenView.ts index 8ba81468..f0977659 100644 --- a/js/mean-and-median/view/MeanAndMedianScreenView.ts +++ b/js/mean-and-median/view/MeanAndMedianScreenView.ts @@ -28,7 +28,7 @@ class MeanAndMedianScreenView extends MeanOrMedianScreenView { isMedianScreen: false, questionBarOptions: { barFill: CAVColors.meanAndMedianQuestionBarFillColorProperty, - labelText: CenterAndVariabilityStrings.meanAndMedianQuestion + questionString: CenterAndVariabilityStrings.meanAndMedianQuestion }, topCheckboxGroupOptions: { medianBarIconOptions: { diff --git a/js/median/view/MedianScreenView.ts b/js/median/view/MedianScreenView.ts index 6b119ed0..151f3c34 100644 --- a/js/median/view/MedianScreenView.ts +++ b/js/median/view/MedianScreenView.ts @@ -28,7 +28,7 @@ class MedianScreenView extends MeanOrMedianScreenView { isMedianScreen: true, questionBarOptions: { barFill: CAVColors.medianQuestionBarFillColorProperty, - labelText: CenterAndVariabilityStrings.medianQuestion + questionString: CenterAndVariabilityStrings.medianQuestion }, topCheckboxGroupOptions: { includeSortData: true, diff --git a/js/variability/view/VariabilityScreenView.ts b/js/variability/view/VariabilityScreenView.ts index 6d960aaf..4b41bffe 100644 --- a/js/variability/view/VariabilityScreenView.ts +++ b/js/variability/view/VariabilityScreenView.ts @@ -26,7 +26,7 @@ class VariabilityScreenView extends SoccerScreenView { const options = optionize()( { questionBarOptions: { barFill: CAVColors.variabilityQuestionBarFillColorProperty, - labelText: CenterAndVariabilityStrings.variabilityQuestion + questionString: CenterAndVariabilityStrings.variabilityQuestion }, tandem: Tandem.REQUIRED }, providedOptions );