From 2cbbec3e517a11789c6e3a018a0dd6fe5b4c6c45 Mon Sep 17 00:00:00 2001 From: matthewblackman Date: Fri, 28 Apr 2023 13:39:05 -0400 Subject: [PATCH] Add TODO for advanceLine issue - see https://github.com/phetsims/center-and-variability/issues/160 --- js/common/model/CAVModel.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/common/model/CAVModel.ts b/js/common/model/CAVModel.ts index f479fc34..5cb95fec 100644 --- a/js/common/model/CAVModel.ts +++ b/js/common/model/CAVModel.ts @@ -445,6 +445,9 @@ export default class CAVModel implements TModel { } } + // TODO: Only advance the line if the CURRENT active player's ball has landed, or the timer after the kick has fired + // TODO: We observed that if Player A's ball is still in flight after Player B kicks, then the landing of Player A's ball will trigger advanceLine for Player B + // When a ball lands, or when the next player is supposed to kick (before the ball lands), move the line forward private advanceLine(): void {