Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe to pick up wire #255

Closed
KatieWoe opened this issue Apr 12, 2019 · 3 comments
Closed

Swipe to pick up wire #255

KatieWoe opened this issue Apr 12, 2019 · 3 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#306. I noted that the bit of wire you move to connect/disconnect different parts of the circuit doesn't have swipe to pick up. But the touch areas are pretty good sized. Since we are looking at phetsims/qa#295, I thought it might be useful to look at.

@phet-steele
Copy link
Contributor

@KatieWoe this feature (swipe to pick up) is called touchSnag. Please see #130 for why touchSnag was disabled, mostly starting at #130 (comment). @arouinfar be aware what you would be reintroducing if you are looking at this for phetsims/qa#295. I don't think it's a worthwhile trade-off to revert all the time spent in #130.

@KatieWoe
Copy link
Contributor Author

Thanks @phet-steele sorry for missing that.

@arouinfar
Copy link

Thanks for the reminder @phet-steele! Since there isn't any real usability issue on touch, I think we can continue leaving touchSnag disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants