-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.6.7-rc.1/phetio] Wrappers do not work #238
Comments
Events: recording works. Need to add the |
I'm not seeing the above issue in master. |
It looks like this version of the index wrapper is filling in links with the phet-io website. Not sure why, but I see that the standalone and instance proxies links work, have you tested those alright? Here is what I'm seeing from the original task. 1.6 (RC, chipper 2.0 BUT not a shared branch with phet brand) Then please test the following links (manually created rather than using the faulty index wrapper). |
@zepumph I have tested all of the links you provided in your last comment and they all work. I have also tested the wrappers that did not work (standalone, events: colorized, events: JSON, and events: recording) in master and they all work as well. If you have links for those wrappers I can them test for you. |
@zepumph I just tested all of the links you gave me and they all work. It must be an issue with the index wrapper as you suggested earlier. |
We will not be fixing this on the branch, and it is fixed in master, closing |
Test device: PC Laptop
OS: Windows 10 OS v. 1803
Browser: Google Chrome v. 67.0.3396.79
Problem description: For phetsims/qa#128 when attempting to use various wrappers with CLB v. 1.6.7-phetio (found in https://github.com/phetsims/phet-io/issues/1329#issue-329557833) certain wrappers do not work even when using the &relativeSimPath and &launchLocalVersion query parameters. The wrappers that are not able to be accessed are the standalone, events: colorized, events: JSON, and events: recording. Due to the fact that events: recording does not work the events: playback wrapper is also unable to be tested. Is there another query parameter that could be used to access these wrappers or is there an issue with this newest version? I have tested all of these wrappers the previous version, 1.6.6, and they all work as expected.
The text was updated successfully, but these errors were encountered: