Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.7-rc.1/phetio] Wrappers do not work #238

Closed
JRomero0613 opened this issue Jun 11, 2018 · 7 comments
Closed

[1.6.7-rc.1/phetio] Wrappers do not work #238

JRomero0613 opened this issue Jun 11, 2018 · 7 comments
Assignees
Labels

Comments

@JRomero0613
Copy link

Test device: PC Laptop

OS: Windows 10 OS v. 1803

Browser: Google Chrome v. 67.0.3396.79

Problem description: For phetsims/qa#128 when attempting to use various wrappers with CLB v. 1.6.7-phetio (found in https://github.com/phetsims/phet-io/issues/1329#issue-329557833) certain wrappers do not work even when using the &relativeSimPath and &launchLocalVersion query parameters. The wrappers that are not able to be accessed are the standalone, events: colorized, events: JSON, and events: recording. Due to the fact that events: recording does not work the events: playback wrapper is also unable to be tested. Is there another query parameter that could be used to access these wrappers or is there an issue with this newest version? I have tested all of these wrappers the previous version, 1.6.6, and they all work as expected.

@JRomero0613 JRomero0613 changed the title [1.6.7-phetio] Wrappers do not work [1.6.7-rc.1-phetio] Wrappers do not work Jun 12, 2018
@ghost ghost changed the title [1.6.7-rc.1-phetio] Wrappers do not work [1.6.7-rc.1/phetio] Wrappers do not work Jun 12, 2018
@ghost
Copy link

ghost commented Jun 12, 2018

Events: recording works. Need to add the &console query parameter as well as &relativeSimPath.

@ghost
Copy link

ghost commented Jun 12, 2018

I'm not seeing the above issue in master.

@zepumph
Copy link
Member

zepumph commented Jun 12, 2018

It looks like this version of the index wrapper is filling in links with the phet-io website. Not sure why, but I see that the standalone and instance proxies links work, have you tested those alright? Here is what I'm seeing from the original task.

1.6 (RC, chipper 2.0 BUT not a shared branch with phet brand)
Standalone
Instance Proxies

Then please test the following links (manually created rather than using the faulty index wrapper).
State
Mirror Inputs

@JRomero0613
Copy link
Author

@zepumph I have tested all of the links you provided in your last comment and they all work. I have also tested the wrappers that did not work (standalone, events: colorized, events: JSON, and events: recording) in master and they all work as well. If you have links for those wrappers I can them test for you.

@zepumph zepumph removed their assignment Jun 15, 2018
@JRomero0613
Copy link
Author

@zepumph I just tested all of the links you gave me and they all work. It must be an issue with the index wrapper as you suggested earlier.

@zepumph
Copy link
Member

zepumph commented Jun 28, 2018

We will not be fixing this on the branch, and it is fixed in master, closing

@zepumph zepumph closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants