Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuity points are not at the edges of the discontinuity. #228

Closed
veillette opened this issue Feb 10, 2023 · 5 comments
Closed

Discontinuity points are not at the edges of the discontinuity. #228

veillette opened this issue Feb 10, 2023 · 5 comments
Assignees

Comments

@veillette
Copy link
Contributor

image

@veillette veillette self-assigned this Feb 10, 2023
@veillette
Copy link
Contributor Author

I think I have a good idea of the cause of this artefact.

Below I limited the number of points to 51 to magnify the problem and highlighted all the points.
numberOfPoints=51&screens=3&allPoints=true

image

On the right, in green, I attempted to show where the "real" intersections of the parabola and the line should be.
This intersection does not lie on a point, but between two points. As a result, it creates a small shoulder on the original curve. In turn, the small shoulder creates a non zero derivative.

@veillette
Copy link
Contributor Author

veillette commented Mar 9, 2023

WIth the work in #208, this is working much better for the first derivative.

image

However, there is still some work to be done with the second derivative.

image

@pixelzoom
Copy link
Contributor

Very nice!

@veillette
Copy link
Contributor Author

The work on the second derivative is being tracked in #275

@veillette
Copy link
Contributor Author

Since we are tracking the work of the second derivative in #275, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants