Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the README file #181

Closed
jbphet opened this issue Aug 24, 2023 · 2 comments
Closed

Update the README file #181

jbphet opened this issue Aug 24, 2023 · 2 comments
Assignees
@zepumph @Luisav1
Labels
dev:code-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 24, 2023

From code review, see #165.

The README file appears to be out of date, and says the sim is unpublished, but I think it's been published as a prototype and is about to be published as a full sim, so it's time to make this real.
@jbphet jbphet mentioned this issue Aug 24, 2023
Closed
71 tasks
@zepumph
Copy link
Member

zepumph commented Aug 24, 2023

I believe this is automatically done in grunt production. These are auto generated from templates, and shouldn't be edited directly (which I think you know, but just confirming).

@zepumph
Copy link
Member

zepumph commented Aug 28, 2023

Yes, since this line is only done during grunt production and not during a prototype (and that seems correct to me), I recommend no changes.

@zepumph zepumph closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

@Luisav1 Luisav1

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbphet @zepumph @Luisav1