Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons for adding nucleons can get stuck in disabled state when shuffling listeners #172

Closed
jbphet opened this issue Aug 23, 2023 · 1 comment
Labels
dev:code-review type:bug Something isn't working

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 23, 2023

This was found during the "Does the sim behave correctly when listener order is shuffled?" step of the code review, see #165.

When testing with randomized listener order, the buttons for adding protons, neutrons, and both can be left in a disabled state after a reset.

To duplicate:

  1. Load the sim with the random seed 423809 (I saw this using several seeds, this is just one of them) and go into the "Decay" screen. The URL I used on my system was http://localhost:8080/build-a-nucleus/build-a-nucleus_en.html?brand=phet&ea&listenerOrder=random(423809).
  2. In quick succession, add two protons and then press the reset button
  3. All buttons for adding nucleons end up disabled, (see screenshot below), making the screen basically unusable

image

@jbphet jbphet mentioned this issue Aug 23, 2023
71 tasks
@zepumph zepumph added type:bug Something isn't working dev:code-review labels Aug 28, 2023
@zepumph
Copy link
Member

zepumph commented Aug 28, 2023

Fixed over in #105. Thanks for the report. The bug was actually over in axon, where observableArray needed to lock in its lengthProperty listeners when it was marked as having order dependencies phetsims/axon@4f571cb

@zepumph zepumph closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:code-review type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants