Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow doesn't disappear from half-life chart in some randomized listener cases #171

Closed
jbphet opened this issue Aug 23, 2023 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 23, 2023

This was found during the "Does the sim behave correctly when listener order is shuffled?" step of the code review, see #165.

When testing with shuffled listeners, the magenta arrow on the "Half-life" chart in the "Decay" screen is not always removed from the chart when the nucleus is cleared out.

To duplicate:

  1. Load the sim with the random seed 357123 (I saw this using several seeds, this is just one of them). The URL I used on my system was http://localhost:8080/build-a-nucleus/build-a-nucleus_en.html?brand=phet&ea&listenerOrder=random(357123).
  2. Add a proton using the up arrow button
  3. Remove the proton using the down arrow button (reset works for this too)
  4. Note that the arrow still shows on the chart and the half-life value shows the "Infinity" symbol.

image

When the listeners are not randomized, the same sequence yields the following:

image

@jbphet jbphet added type:question Further information is requested dev:code-review and removed type:question Further information is requested labels Aug 23, 2023
@jbphet jbphet mentioned this issue Aug 23, 2023
71 tasks
@zepumph
Copy link
Member

zepumph commented Aug 25, 2023

Fixed over in with #105 with phetsims/axon@4f571cb. Thanks for the report.

@zepumph zepumph closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants