Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecayEquationModel only needs the cellModellArray[ protonNumber ] row instead of the whole cellModelArray #154

Closed
Luisav1 opened this issue Aug 18, 2023 · 2 comments

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 18, 2023

From #112.

@Luisav1 Luisav1 self-assigned this Aug 18, 2023
@zepumph
Copy link
Member

zepumph commented Aug 21, 2023

I'm not sure that is true, because we link to updates whenever the protonNumber changes. Should we just keep things as is?

massNumberProperty.link( () => {
const currentCell = this.getCurrentCellModel( cellModelArray, protonCountProperty.value, massNumberProperty.value );

@zepumph zepumph assigned zepumph and unassigned Luisav1 Aug 21, 2023
@zepumph zepumph assigned Luisav1 and unassigned zepumph Aug 21, 2023
@Luisav1
Copy link
Contributor Author

Luisav1 commented Aug 23, 2023

Yes that makes sense. Things should be kept as is. Thanks @zepumph. Closing.

@Luisav1 Luisav1 closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants