Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't fireOnHold work for the nuclide buttons? #114

Closed
zepumph opened this issue Aug 3, 2023 · 2 comments
Closed

Shouldn't fireOnHold work for the nuclide buttons? #114

zepumph opened this issue Aug 3, 2023 · 2 comments
Assignees
@zepumph @Luisav1

Comments

@zepumph
Copy link
Member

zepumph commented Aug 3, 2023 •
edited
Loading

This is in the DoubleArrowButton:

  // options related to fire-on-hold feature
      fireOnHold: true,
      fireOnHoldDelay: 400, // start to fire continuously after pressing for this long (milliseconds)
      fireOnHoldInterval: 100 // f

But it wasn't working this morning during design meeting with @ariel-phet.
@zepumph
Copy link
Member Author

zepumph commented Aug 3, 2023

Looks like it is opted out of in

build-a-nucleus/js/common/view/BANScreenView.ts

Line 204 in 67fafea

fireOnHold: false
.

History is in #31.

We should at least clean up these defaults since it is all in sim-specific code.

@zepumph
Copy link
Member Author

zepumph commented Aug 3, 2023

Working on this cleanup now.

@zepumph zepumph closed this as completed in 0fd165b Aug 3, 2023
@Nancy-Salpepi Nancy-Salpepi mentioned this issue Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

@Luisav1 Luisav1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1