From a180546a1f7c50a3c315b17e64fce3c9e37c80a2 Mon Sep 17 00:00:00 2001 From: Michael Kauzmann Date: Mon, 28 Aug 2023 12:10:56 -0600 Subject: [PATCH] handle review comments, https://github.com/phetsims/build-a-nucleus/issues/165 --- js/common/model/BANModel.ts | 2 +- js/decay/model/DecayModel.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/js/common/model/BANModel.ts b/js/common/model/BANModel.ts index 2bef6cb..3775d07 100644 --- a/js/common/model/BANModel.ts +++ b/js/common/model/BANModel.ts @@ -108,7 +108,7 @@ class BANModel { this.particles.addItemAddedListener( particle => { - // REVIEW: Should there be an unlink for when the particles are removed? If unnecessary, document why. + // No need to remove because when a particle is removed from this.particles, it is disposed particle.userControlledProperty.link( isUserControlled => userControlledListener( isUserControlled, particle ) ); } ); diff --git a/js/decay/model/DecayModel.ts b/js/decay/model/DecayModel.ts index 7c1dcf2..382664b 100644 --- a/js/decay/model/DecayModel.ts +++ b/js/decay/model/DecayModel.ts @@ -20,7 +20,8 @@ class DecayModel extends BANModel { // the half-life number public halfLifeNumberProperty: TReadOnlyProperty; - // REVIEW: Some docs about this field would be helpful. + // A data structure for all the enabledProperties for the "decay buttons". These enabledProperties toggle to enabled + // when the Nuclide supports that given decay type. public decayEnabledPropertyMap: Map>; public constructor() {