Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using two fingers on touch enabled devices causes atom spread in molecules #144

Closed
loganbraywork opened this issue Jan 17, 2020 · 5 comments
Assignees
Labels

Comments

@loganbraywork
Copy link

Test device
Hanson
Operating System
Windows 10
Browser
Chrome
Problem description
Similar to #118 but can lead to buggier behavior if two fingers continue to be used.
When two fingers are used on a built molecule it causes the atoms to change distance from each other but the molecule to not break apart which can lead to further buggy behavior
Steps to reproduce

  1. Enter the lab screen
  2. Build a molecule
  3. Using a touch enabled computer, manipulate both atoms of the molecule simultaneously using two fingers
    Visuals
    molecules lightedge
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Build a Molecule‬ URL: http://phettest.colorado.edu/build-a-molecule/build-a-molecule_en.html?ea&brand=phet Version: 0.0.0-dev.40 (require.js) Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36 Language: en-US Window: 1280x610 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
@loganbraywork
Copy link
Author

loganbraywork commented Jan 17, 2020

Can also cause a crash similar to #141 if spread out molecules are placed into the buckets

@Denz1994
Copy link
Contributor

Denz1994 commented Mar 4, 2020

Can you confirm this is fixed in this dev version @loganbraywork?

@Denz1994
Copy link
Contributor

Denz1994 commented Apr 8, 2020

Adding @KatieWoe to this confirm this issue, due to QA devices being moved between members. This dev version should have the same fixes from above. Atoms shouldn't be separated when dragging with two fingers.

@KatieWoe
Copy link
Contributor

KatieWoe commented Apr 8, 2020

This issue seems fixed from what I can tell in that dev version

@KatieWoe KatieWoe assigned Denz1994 and unassigned KatieWoe Apr 8, 2020
@Denz1994
Copy link
Contributor

Denz1994 commented Apr 8, 2020

Nice. Closing.

@Denz1994 Denz1994 closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants