Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push atoms into the answer box #133

Closed
KatieWoe opened this issue Dec 7, 2019 · 6 comments
Closed

Push atoms into the answer box #133

KatieWoe opened this issue Dec 7, 2019 · 6 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 7, 2019

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
Found in https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.28/phet/build-a-molecule_en_phet.html?dev while testing fixed issues. Fairly minor. It is possible to push atoms into the answer area even though they would normally be pushed out.
Steps to reproduce

  1. Make part of a molecule
  2. Put it beside the answer box
  3. Cut the molecule apart

Visuals
jumpinthebox

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Build a Molecule‬
URL: https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.28/phet/build-a-molecule_en_phet.html?dev
Version: 0.0.0-dev.28 2019-12-05 16:25:33 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@Denz1994
Copy link
Contributor

Related to #120

@Denz1994
Copy link
Contributor

This may have been corrected due to changing play area bounds in #120. Can you confirm this isn't an issue in this dev version @KatieWoe?

@KatieWoe
Copy link
Contributor Author

This does seem fixed, but I noticed that the molecules move back to the play area in two disjointed steps.
doublejump

@KatieWoe KatieWoe removed their assignment Jan 21, 2020
@Denz1994
Copy link
Contributor

Right this disjointed action is due to using both the kit.separationMoleculeDestinations() and Twixt animation support. We can get away with using just the Kit's model to handle the bounds for the molecules along with constraining them to those kit bounds.

I removed support for the animation behavior so we are solely relying on kit.js to do this for us.

The behavior has been updated in this dev version. Can you review @KatieWoe?

@Denz1994 Denz1994 assigned KatieWoe and unassigned Denz1994 Jan 22, 2020
@loganbraywork
Copy link

Appears to be fixed

@loganbraywork loganbraywork assigned Denz1994 and unassigned KatieWoe Jan 22, 2020
@Denz1994
Copy link
Contributor

Nice closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants