Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible answer box? #119

Closed
KatieWoe opened this issue Nov 22, 2019 · 8 comments
Closed

Invisible answer box? #119

KatieWoe opened this issue Nov 22, 2019 · 8 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#459
There seems to be an area on the right of the play area in the last screen that molecules can't be placed of used. They move as if an answer box is there, even though there isn't.
Steps to reproduce

  1. Go to the last screen
  2. Drag something far to the right and let go, note the apparent edge of the play area the object returns to.
  3. Click the object or drag it slightly to the left

Visuals
doublejump

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Build a Molecule‬
URL: https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.23/phet/build-a-molecule_all_phet.html
Version: 0.0.0-dev.23 2019-11-20 23:29:39 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe
Copy link
Contributor Author

Similar behavior:
slightlyrelated

@KatieWoe
Copy link
Contributor Author

Happens a bit on the left side of the screen too.

@Denz1994
Copy link
Contributor

There are playAreaBounds that are set on each screen which the molecules animate to. The 3rd screen needs a different set of bounds that extends a bit further to the right.

@Denz1994
Copy link
Contributor

This cc2f233 should have fixed the exaggerated bounds on the right side. Could @arouinfar review the size of the play area bounds?

@Denz1994
Copy link
Contributor

Also, the refill and resetAllButton (on 3rd screen) are included in these bounds. This means there can be overlap with the atoms when dragged to the corner. Maybe the playAreaBounds should be a custom Shape instead of rectangular bounds.

@Denz1994 Denz1994 assigned arouinfar and unassigned Denz1994 Nov 24, 2019
@arouinfar
Copy link
Contributor

@Denz1994 things are looking good in master. I don't think we need to do anything special for the ResetAllButton. If the button is obscured, it's because a user put something in front of it. They can simply drag the molecule out of the way. There's also precedent for this sort of behavior in expression-exchange. There, coins can be dragged in front of the ResetAllButton.

image

@Denz1994
Copy link
Contributor

Denz1994 commented Dec 6, 2019

@KatieWoe This invisible box bugginess should be fixed in this dev version.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Dec 6, 2019

Looks good in the dev version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants