From b8bb4a005ac090e255abe51f6957750075471e3b Mon Sep 17 00:00:00 2001 From: Chris Malley Date: Mon, 14 Jan 2019 18:41:17 -0700 Subject: [PATCH] big ComboBox refactors, https://github.com/phetsims/sun/issues/430, https://github.com/phetsims/sun/issues/428, https://github.com/phetsims/sun/issues/419 --- js/beerslaw/view/SolutionComboBox.js | 6 ++++-- js/concentration/view/SoluteComboBox.js | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/js/beerslaw/view/SolutionComboBox.js b/js/beerslaw/view/SolutionComboBox.js index 177ea718..04c5a9cd 100644 --- a/js/beerslaw/view/SolutionComboBox.js +++ b/js/beerslaw/view/SolutionComboBox.js @@ -45,8 +45,10 @@ define( function( require ) { ComboBox.call( this, items, selectedSolutionProperty, solutionListParent, { labelNode: label, listPosition: 'above', - itemYMargin: 12, - itemHighlightFill: 'rgb(218,255,255)', + xMargin: 12, + yMargin: 16, + arrowHeight: 20, + highlightFill: 'rgb( 218, 255, 255 )', tandem: tandem } ); } diff --git a/js/concentration/view/SoluteComboBox.js b/js/concentration/view/SoluteComboBox.js index 8385a28b..4a9239ab 100644 --- a/js/concentration/view/SoluteComboBox.js +++ b/js/concentration/view/SoluteComboBox.js @@ -45,8 +45,10 @@ define( function( require ) { ComboBox.call( this, items, selectedSoluteProperty, soluteListParent, { labelNode: labelNode, listPosition: 'below', - itemYMargin: 12, - itemHighlightFill: 'rgb(218,255,255)', + xMargin: 12, + yMargin: 16, + arrowHeight: 20, + highlightFill: 'rgb( 218, 255, 255 )', tandem: tandem } ); }