Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot base class #37

Closed
pixelzoom opened this issue Jun 15, 2021 · 1 comment
Closed

Plot base class #37

pixelzoom opened this issue Jun 15, 2021 · 1 comment
Assignees
@samreid
Labels
type:duplicate This issue or pull request already exists type:question Further information is requested

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 15, 2021 •
edited
Loading

I have been wondering if there should be a Plot.js base class. There's starting to be duplication, as well as some undesirable variation, amoung the plot classes. And if you're trying to create a new plot class, it's not totally clear what the required interface/API is.

@samreid thoughts?
@pixelzoom pixelzoom added the type:question Further information is requested label Jun 15, 2021
@samreid
Copy link
Member

samreid commented Jun 15, 2021

I opened #35 to factor out commonalities between existing Plot classes. I'll add your comment there and close this as a duplicate.

@samreid samreid closed this as completed Jun 15, 2021
@samreid samreid added the type:duplicate This issue or pull request already exists label Jun 15, 2021
@samreid samreid mentioned this issue Jun 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
type:duplicate This issue or pull request already exists type:question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom